chore: REMOVE IMAGE_INLINE_SIZE_LIMIT variable #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 8b6903d): https://ccv-honeycomb--pr447-chore-inline-vl45atdq.web.app (expires Fri, 12 Apr 2024 19:37:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
eldu
approved these changes
Apr 3, 2024
Contributor
eldu
left a comment
There was a problem hiding this comment.
Approving. I did add a comment, but nothing actionable really
.nvmrc
Outdated
| @@ -1 +1 @@ | |||
| v18.17.1 | |||
Contributor
There was a problem hiding this comment.
This the sort of change I wouldn't expect in this PR. And instead in a PR that was about upgrading node.
But, I guess this is just some clean up after that fact?
Member
Author
There was a problem hiding this comment.
Hmm... I think the PR is out of date with feat-3.4, because I did have a separate pr for upgrading node
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stale environment variable that doesn't really matter? Images should be added to the
public/folder and jsPsych now respects that. We should be dealing with any users adding images tosrc/anymore.I know it makes for a few empty environment files but I think that's okay. I want to beef up the documentation of how to use the environment variables in which case have the "home" vs "clinic" is still pertinent