feat: add typedef.js in lib and update documentation in index.js to r… #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eflect this change as example
|
Visit the preview URL for this PR (updated for commit 2d3b804): https://ccv-honeycomb--pr504-add-typedef-96fu5p7y.web.app (expires Tue, 16 Jul 2024 03:31:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
RobertGemmaJr
approved these changes
Jul 8, 2024
Member
RobertGemmaJr
left a comment
There was a problem hiding this comment.
Fantastic! I assume you did a sweep of other files in the project? There may be a few places where jsPsych {Object} is still being used. I'd do a quick check of that and then get this merged!
…into add-typedef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typedef.jsfile insrc/libJsPsychtype from gearshift into this fileeslintto includetypedef.jsindex.jsforbuildTimeLinefunction from general object toJsPsychJsPsychtype for@paramdocumentations for functions where it's applicable?