ref: Electron forge config file #311
Conversation
|
Visit the preview URL for this PR (updated for commit 24968c8): https://ccv-honeycomb--pr311-feat-electron-forge-pxkghmho.web.app (expires Thu, 16 Nov 2023 16:28:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
forge.config.js
Outdated
| name: "@electron-forge/maker-squirrel", | ||
| config: { | ||
| // TODO: Honeycomb icon (hexagon on docs) | ||
| // TODO: This will break when we merge with main |
There was a problem hiding this comment.
Is this an issue for existing honeycomb users or is it just the icon so they'll get like a missing image?
There was a problem hiding this comment.
The URL is point to main and we're changing the path to that file so we'll have to update it when this PR gets into main (it's going into a different branch right now)
There was a problem hiding this comment.
Oh wait I can totally update the URL here for now, no one's going to be packaging based on this branch
There was a problem hiding this comment.
Passing through ! 🏃
There are quite a few TODO statements here which look they they could be resolved by adding in the honeycomb icon png. Which could probably be done in this pr
I do like moving the forge config into it's own file though !
Also the check for the macOS build isn't going through
digicosmos86
left a comment
There was a problem hiding this comment.
Looks great! I only have one question about native support for ARM macs.
package.json
Outdated
| "package": "npm run build && electron-forge make", | ||
| "package:windows": "npm run package -- --arch x64 --targets @electron-forge/maker-squirrel", | ||
| "package:linux": "npm run package -- --arch x64 --targets @electron-forge/maker-deb", | ||
| "package:mac": "npm run package -- --arch x64 --targets @electron-forge/maker-dmg" |
There was a problem hiding this comment.
Looks like this does not support ARM macs natively right? Is there an option that supports a universal build?
There was a problem hiding this comment.
Looks like there is a universal value now, I'll swap it in!
@digicosmos86 @eldu have you run into node gyp errors on Mac before? The build is failing on the |
@RobertGemmaJr Perhaps upgrade node-gyp? It's at 10.0.1 |
|
Oh node-gyp is not a direct dependency, nvm. |
forge.config.jsconfiguration filepackagescriptpackage:<windows|mac|linux>now build off the package scriptassets/icons