fix: tolerate account update timeouts #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the run alive when reqAccountUpdatesAsync never finishes but portfolio data is still available. We now only retry the request on the first two attempts and fall back on the third, logging that the snapshot is stale before continuing to reconcile holdings. Tests cover both the new fallback and the existing retry behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the run alive when reqAccountUpdatesAsync never finishes but portfolio data is still available. We now only retry the request on the first two attempts and fall back on the third, logging that the snapshot is stale before continuing to reconcile holdings. Tests cover both the new fallback and the existing retry behaviour.