Brthor/cli nuget tools #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classes. Write Unit Tests covering Composite DefaultCommandResolver and ScriptCommandResolver.
…l need work as that story fleshes out.
|
|
||
| public IEnumerable<string> InferredExtensions { get; set; } | ||
|
|
||
| public IEnvironmentProvider Environment { get; set; } |
There was a problem hiding this comment.
This does not seem like an Argument. Should this be passed in to the implementations of ICommandResolver?
Owner
Author
There was a problem hiding this comment.
I had it the way you are suggesting at first, but went back to this because it made it a little easier to test.
I agree though that is a cleaner approach, will make that change back.
5e6feef to
3479cbe
Compare
| Framework = FrameworkConstants.CommonFrameworks.DnxCore50, | ||
| Configuration = "Debug" | ||
| }; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.