Conversation
Owner
Author
|
The tests pass, and everything looks golden. I'll merge this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch implements something that Antidote1911 and I spoke about. They mentioned that streaming mode is compatible with files smaller than
BLOCK_SIZE, and they were right.I was under the assumption that
StreamLE31::encrypt_lastdid some wizardry under-the-hood, and opted to keep both modes. It turns out thatencrypt_lastjust takes ownership of the STREAM object, to prevent it from being used further.Decrypting files that were encrypted in memory-mode is still supported, but streaming mode is now used by default for all files - no matter the size.
I'd like to thank Antidote1911 for pointing this out to me!