Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Not validate "video.minduration" and "maxduration" #69

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Not validate "video.minduration" and "maxduration" #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions video.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@ import (

// Validation errors
var (
ErrInvalidVideoNoMIMEs = errors.New("openrtb: video has no mimes")
ErrInvalidVideoNoLinearity = errors.New("openrtb: video linearity missing")
ErrInvalidVideoNoMinDuration = errors.New("openrtb: video min-duration missing")
ErrInvalidVideoNoMaxDuration = errors.New("openrtb: video max-duration missing")
ErrInvalidVideoNoProtocols = errors.New("openrtb: video protocols missing")
ErrInvalidVideoNoMIMEs = errors.New("openrtb: video has no mimes")
ErrInvalidVideoNoLinearity = errors.New("openrtb: video linearity missing")
ErrInvalidVideoNoProtocols = errors.New("openrtb: video protocols missing")
)

// Video object must be included directly in the impression object if the impression offered
Expand Down Expand Up @@ -53,10 +51,6 @@ func (v *Video) Validate() error {
return ErrInvalidVideoNoMIMEs
} else if v.Linearity == 0 {
return ErrInvalidVideoNoLinearity
} else if v.MinDuration == 0 {
return ErrInvalidVideoNoMinDuration
} else if v.MaxDuration == 0 {
return ErrInvalidVideoNoMaxDuration
} else if v.Protocol == 0 && len(v.Protocols) == 0 {
return ErrInvalidVideoNoProtocols
}
Expand Down
9 changes: 0 additions & 9 deletions video_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,6 @@ var _ = Describe("Video", func() {
Expect((&Video{
MIMEs: []string{"video/mp4"},
}).Validate()).To(Equal(ErrInvalidVideoNoLinearity))
Expect((&Video{
Linearity: VideoLinearityNonLinear,
MIMEs: []string{"video/mp4"},
}).Validate()).To(Equal(ErrInvalidVideoNoMinDuration))
Expect((&Video{
MinDuration: 1,
Linearity: VideoLinearityNonLinear,
MIMEs: []string{"video/mp4"},
}).Validate()).To(Equal(ErrInvalidVideoNoMaxDuration))
Expect((&Video{
MinDuration: 1,
MaxDuration: 1,
Expand Down