Fix targets ordering when containing numerical value as name #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c19eafc to
18c3a1e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2314 +/- ##
==========================================
- Coverage 76.85% 75.21% -1.65%
==========================================
Files 51 51
Lines 4126 4236 +110
==========================================
+ Hits 3171 3186 +15
- Misses 955 1050 +95
Continue to review full report at Codecov.
|
f9c3c31 to
380d88e
Compare
kt3k
reviewed
Apr 10, 2018
| return { keys, rows: newRows }; | ||
| }; | ||
|
|
||
| c3_chart_internal_fn.convertDataToTargets = function (data, appendXs) { |
There was a problem hiding this comment.
Now the shape of data is changed to { keys, rows }. I think we should document that in jsdoc format like:
/**
* Converts the data format into the target format.
* @param {Array} data.keys ...describe...
* @param {Array} data.rows ...describe...
* @param {boolean} appendXs
*/
kt3k
reviewed
Apr 10, 2018
spec/data.convert.js
Outdated
|
|
||
| // FIXME: how to have a proper testing environment? | ||
| const $$ = c3.chart.internal.fn; | ||
| $$.d3 = window.d3 ? window.d3 : typeof require !== 'undefined' ? require("d3") : undefined; |
There was a problem hiding this comment.
I think require("d3") must be available in testing environment and this can be $$.d3 = require("d3")
…nvert methods. This fixes the issue where targets order would not be kept when some of them have numerical values (ex: "1", "2", ..).
380d88e to
9f0e23f
Compare
|
@kt3k Thanks for the review, I updated the PR accordingly. edit: Not sure why codecov says the coverage will decrease that much in all those files though. |
|
I confirmed the data order preseved in this example with this change: var chart = c3.generate({
data: {
columns: [
['data5', 30],
['data1', 130],
['2', 35],
['data4', 60],
['data3', 100]
],
type: 'bar'
}
});Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to fix issue where
data.order: nullwould still not leave the data order untouched if targets have numerical values.The idea of this update is to keep the ordered keys as an array in the pivot format returned by convert methods.