Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use util function to detect IE9 in getClipPath() #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

Use util function to detect IE9 in getClipPath() #2743

merged 1 commit into from
Jan 30, 2020

Conversation

@GDFaber
Copy link
Contributor

@GDFaber GDFaber commented Jan 29, 2020

  • replaced local IE9 detection by using isIE(9) from util.js
  • corrected unit test for isIE(6) to check return value being false

kt3k
kt3k approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GDFaber Thanks! LGTM.

@kt3k kt3k merged commit 01981e3 into c3js:master Jan 30, 2020
@GDFaber GDFaber deleted the maintenance/use_isIE_to_detect_IE9_in_getClipPath branch February 24, 2020 15:15
@saadcss saadcss mentioned this pull request Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kt3k kt3k kt3k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GDFaber @kt3k