feat: allow client to be configure with urls instead of metadata #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR. I think it makes sense having this. I am not sure about the way this can be configured. Having a bunch of "optional" fields, and then (if all of them are set) using a different approach. Maybe we can make this a bit more explicit by having an enum? Something like: struct Config {
source: Source,
}
enum Source {
Discovery,
Manual {
auth: Url,
…
},
} |
Contributor
Author
|
That's a good idea, we could make the |
Contributor
Author
|
@ctron Thank you for the feedback, it's way cleaner now |
ctron
approved these changes
Sep 10, 2025
Owner
|
Released as 0.12.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the client to be configured without using the discovery document