Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

alathon
Copy link
Contributor

@alathon alathon commented Apr 14, 2020

This PR does two things:

  1. Allows the action to specify a data_file, to support setting variables from a file instead of from the action itself.
  2. Correctly passes subprocess exit code, meaning if jinja2 has non-zero exit then the action will properly fail.

This commit adds support for a data_file argument
to the action. It also fixes a bug where the Subprocess
exit code wouldn't be used by the GitHub action.
@alathon alathon marked this pull request as ready for review April 14, 2020 15:09
Copy link
Owner

@cuchi cuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cuchi cuchi merged commit 70b631c into cuchi:master Apr 14, 2020
forklebot bot pushed a commit to rmd-actions/jinja2-action that referenced this pull request Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants