Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gherkin/javascript: Include tags from rules in scenario outlines #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpkorstanje merged 2 commits into from
Oct 10, 2022
Merged

gherkin/javascript: Include tags from rules in scenario outlines #2091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6e976c
Update the compileRule function of javascript
chaofan-nirvana Sep 30, 2022
7d465fa
PR-2091 Update the changelog. Using the same pattern of the compileRu…
chaofan-nirvana Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gherkin/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt

### Fixed

* [Javascript] Fix compiling a rule with scenario outline of gherkin document is different from ruby's ([#2091](https://github.com/cucumber/common/pull/2091))
* [Python] Fix gherkin-python for compiling example values with trailing backslash ([#2048](https://github.com/cucumber/common/pull/2048), [#1954](https://github.com/cucumber/common/issues/1954))
* [PHP] Disallow installation of Messages `18.x` ([#2034](https://github.com/cucumber/common/pull/2034))

Expand Down
2 changes: 1 addition & 1 deletion gherkin/javascript/src/pickles/compile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ function compileRule(
)
} else {
compileScenarioOutline(
featureTags,
tags,
ruleBackgroundSteps,
stepsContainer.scenario,
language,
Expand Down