Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sashokbg
Copy link

@sashokbg sashokbg commented Feb 22, 2023

🤔 What's changed?

Added the ability to register custom token matcher for custom "gherkin flavors".
"generateMessages" and "makeSourceEnvelopes" will try to match the file extension / media type with the according custom flavor and use the appropriate matcher.

⚡️ What's your motivation?

I would like to implement a custom "flavor" using asciidoc much like the one with markdown that already exists in the repository.

Also implementing such feature adds an SPI-like capabilities for everyone to implement whatever they like as "flavors" and keeps the open / close principle.

related to #10

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • [X ] I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@sashokbg
Copy link
Author

sashokbg commented Mar 5, 2023

bump any comments/discussion are greatly appreciated @aslakhellesoy

@sashokbg sashokbg force-pushed the feat/custom_flavor_registry branch from 1bc0f5c to 0c3fad0 Compare March 13, 2023 13:21
@luke-hill
Copy link
Contributor

ping @davidjgoss probably best you review this imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants