Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lgarron
Copy link
Member

@lgarron lgarron commented Aug 14, 2025

No description provided.

@lgarron lgarron requested a review from jfly August 14, 2025 22:55
@lgarron lgarron force-pushed the describe-build-process branch from b19ffe4 to ed8e18c Compare August 14, 2025 23:08
Copy link
Member

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like unnecessary, bitrot-prone prose-ification of our Makefiles.

My slight preference would be not to merge this. However, I don't have any concerns with merging it either, so do what you want with it.

@FatBoyXPC
Copy link
Member

I'm inclined to agree with @jfly here. It's very important for the readme to let users know how to build, but I'm not sure it's so important describe what is happening in the build process. I view readme's as what information a newcomer needs to know in order to use the thing.

@lgarron
Copy link
Member Author

lgarron commented Aug 15, 2025

My slight preference would be not to merge this. However, I don't have any concerns with merging it either, so do what you want with it.

I'm inclined to agree with @jfly here.

Sounds good, that's also my preference. At least we have a this PR as thorough answer to #196 (review) we can reference in the future if needed.

@lgarron lgarron closed this Aug 15, 2025
@lgarron
Copy link
Member Author

lgarron commented Aug 15, 2025

Actually, what I think I can do is turn this into an ADR (architecture decision record).

Not sure what the best public reference on this is, but https://github.com/joelparkerhenderson/architecture-decision-record roughly covers it.

This has the benefit of being a point-in-time documentation that does not make any promises about future maintenance.

@lgarron lgarron deleted the describe-build-process branch August 21, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants