Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Set -arch in the compiler options unconditionally #8157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2024
Merged

Set -arch in the compiler options unconditionally #8157

merged 2 commits into from
Feb 5, 2024

Conversation

@leofang
Copy link
Member

@leofang leofang commented Feb 4, 2024

Close #8155.

I verified locally that this is the right fix, see my analysis in #8155 (comment). Also, I assume this patch must have been used by @mrakgr in his journey of #8156? 🙂

@leofang leofang added cat:bug Bugs to-be-backported Pull-requests to be backported to stable branch labels Feb 4, 2024
@leofang
Copy link
Member Author

leofang commented Feb 4, 2024

/test mini

@mrakgr
Copy link

mrakgr commented Feb 4, 2024

Also, I assume this patch must have been used by @mrakgr in his journey of #8156? 🙂

@leofang I was only using jitify for the cstdint header, so by the time you made the patch I had already modified the Spiral codegen to print various integer types as regular C types instead of int8_t and such, thus removing the dependency on it. 😓

@leofang
Copy link
Member Author

leofang commented Feb 5, 2024

/test mini

@takagi takagi self-assigned this Feb 5, 2024
@takagi takagi added this to the v14.0.0a1 milestone Feb 5, 2024
takagi
takagi approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@takagi takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi merged commit 085a34f into cupy:main Feb 5, 2024
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Feb 5, 2024
@takagi @chainer-ci
Merge pull request cupy#8157 from leofang/jitify_fix2
0a82e95 
Set `-arch` in the compiler options unconditionally
@chainer-ci chainer-ci mentioned this pull request Feb 5, 2024
Merged
@leofang leofang deleted the jitify_fix2 branch February 5, 2024 10:06
@kmaehashi kmaehashi mentioned this pull request Aug 22, 2024
Merged
@kmaehashi kmaehashi mentioned this pull request Feb 26, 2025
Merged
@kmaehashi kmaehashi mentioned this pull request Jun 26, 2025
Merged
@kmaehashi kmaehashi mentioned this pull request Aug 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@takagi takagi takagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@takagi takagi

Labels

cat:bug Bugs prio:high to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Milestone

v14.0.0a1

Development

Successfully merging this pull request may close these issues.

Incomplete type when compiling a wmma::fragment type with jitify

3 participants

@leofang @mrakgr @takagi