ENH,MAINT: Allow cupy-like protocols in setitem and consolidate #9418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `cupy_arr[...] = cupy_like` where cupy-like supports the CUDA array interface or `__cupy_get_ndarray__`. Since there were a few (not many!) places that have a similar logic I, opionatedly, consolidated them into a `cdef inline` function. Similarly moved the test helper classes to not have to repeat them. The biggest part of the diff is just moving those helpers! I am very sure that `cdef inline` must be in the `.pyd` file to actually be inlined (which means many are currenlty not).
7c126f0 to
c259a88
Compare
|
/test mini |
asi1024
approved these changes
Oct 15, 2025
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
cupy_arr[...] = cupy_likewhere cupy-like supports the CUDA array interface or__cupy_get_ndarray__.Since there were a few (not many!) places that have a similar logic I, opionatedly, consolidated them into a
cdef inlinefunction. Similarly moved the test helper classes to not have to repeat them.The biggest part of the diff is just moving those helpers!
I am very sure that
cdef inlinemust be in the.pydfile to actually be inlined (which means many are currenlty not).Closes gh-9089