trurl: "normalize" query pairs #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To properly handle https://example.com/?%611&a2&a3 --trim query=a*, trurl now "normalizes" the query pairs by an extra round of URL decode + encode. If a query pair gets normalized, consider it modified which in turn triggers a URL update. Thus trurl 'https://example.com/?%611&a2&a3' outputs https://example.com/?a1&a2&a3 The query part URL encodes spaces to pluses (and vice versa). Note that %20 in the query in the input URL will be normalized to a +. Updated several tests accordingly. Reported-by: Emanuele Torre Fixes #326 Closes #328
de39ac2 to
520f988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly handle https://example.com/?%611&a2&a3 --trim query=a*, trurl now "normalizes" the query pairs by an extra round of URL decode + encode.
If a query pair gets normalized, consider it modified which in turn triggers a URL update. Thus
trurl 'https://example.com/?%611&a2&a3'
outputs
https://example.com/?a1&a2&a3
The query part URL encodes spaces to pluses (and vice versa). Note that %20 in the query in the input URL will be normalized to a +.
Updated several tests accordingly.
Reported-by: Emanuele Torre
Fixes #326