reorder and always show selective attribute #9802
Open
+14,633
−4,099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added drag-and-drop support for reordering attributes in the label form. - Introduced utility functions for safe array manipulation and validation. - Enhanced the UI with visual feedback for drag handles and tooltips. - Updated tests to cover new reordering features and ensure functionality remains intact after reordering. - Added Cypress commands for streamlined attribute manipulation in tests.
- Updated the attribute submission logic to use the current order from form values instead of fieldInstances. - Added debug logging to track attribute order before and after reordering actions. - Ensured re-rendering of the component after attribute reordering to reflect changes immediately.
- Updated the attribute rendering logic in CanvasView to use the order defined in the label constructor, ensuring consistency with the label's attribute definitions. - Introduced a new utility function to order attributes based on job configuration, allowing for dynamic attribute ordering in ObjectItemDetails. - Modified the ObjectItemDetails component to utilize the new ordering function, improving the display of attributes according to the job's specifications.
- Introduced selective display settings in the canvas model, allowing users to enable or disable the display of specific labels and attributes. - Updated the canvas view to filter attributes based on the new selective display settings, ensuring only relevant details are shown. - Added action creators and reducers to manage selective display settings in the Redux store. - Enhanced the workspace settings modal to include options for configuring selective display preferences. - Implemented utility functions to filter attributes and labels according to the selective display settings, improving the user experience in the annotation workflow.
- Updated the CanvasView implementation to manage selective display changes more effectively. - Added logic to re-render text elements based on updated selective display settings, ensuring accurate representation of labels and attributes. - Improved the condition for recreating text elements to include selective display configurations, enhancing user experience in the annotation workflow.
- Introduced a selective display feature allowing users to show object details based on specific labels and attributes in workspace settings. - Added UI controls for selecting labels and attributes, with immediate application of changes without needing to reload the workspace. - Implemented action creators and reducers to manage selective display settings in the Redux store. - Created comprehensive tests for actions, reducers, and utility functions related to selective display. - Documented the feature in the changelog and user documentation for clarity on usage and functionality.
- Removed debug logging for attribute order comparisons in the label form to streamline the submission process. - Updated error handling comments for clarity when rendering attribute inputs. - Enhanced comments in the attribute ordering utility to improve code readability and understanding of the mapping process.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
#7370
and I wanted to be able to view a specific attribute on the page all at once while inspecting.
How has this been tested?
Test reorder
setting order(text, strikethrough, underline, is_last_in_line) -> check in canvas
setting order(text, is_last_in_line, strikethrough, underline) -> check in canvas
Test always show selective attribute
Non Check Enable selective object details display
Check Enable selective object details display
Set Attribute want to always show
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.