Fix double action menu #9986
Open
Fix double action menu #9986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9986 +/- ##
===========================================
+ Coverage 73.45% 73.53% +0.07%
===========================================
Files 427 428 +1
Lines 46244 46254 +10
Branches 4132 4133 +1
===========================================
+ Hits 33968 34011 +43
+ Misses 12276 12243 -33
🚀 New features to boost your workflow:
|
bsekachev
reviewed
Nov 7, 2025
Comment on lines
36
to
37
| const itemRef = useRef<HTMLDivElement>(null); | ||
| const handleContextMenuClick = useContextMenuClick(itemRef); |
Member
There was a problem hiding this comment.
I believe you may put useRef to useContextMenuClick to reduce duplication
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Applied fix for a couple of problems that can cause actions menu for cards to open twice.
Removed wrapper over actions menu button and added explicit dispatch of right click event to context menu, with this logic we will have only one menu.
Related #9949
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.