Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@klakhov
Copy link
Contributor

@klakhov klakhov commented Nov 7, 2025

Motivation and context

When we open task with several assigned jobs UI sends a user request per each assignee:
image

This is caused by useEffect that reacts to value change, but it also runs on initial setup when we didnt fetch initial users

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov requested a review from bsekachev as a code owner November 7, 2025 13:13
@klakhov klakhov added the ui/ux label Nov 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.45%. Comparing base (acabee6) to head (08d9d3a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9989   +/-   ##
========================================
  Coverage    73.45%   73.45%           
========================================
  Files          427      427           
  Lines        46244    46244           
  Branches      4132     4132           
========================================
+ Hits         33968    33970    +2     
+ Misses       12276    12274    -2     
Components Coverage Δ
cvat-ui 76.91% <ø> (+<0.01%) ⬆️
cvat-server 70.53% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@bsekachev bsekachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop a line to changelog

@klakhov klakhov changed the title Fix excessive user requets from user selector component Fix excessive user requests from user selector component Nov 10, 2025
@klakhov klakhov requested a review from nmanovic as a code owner November 10, 2025 10:43
@sonarqubecloud
Copy link

@klakhov klakhov merged commit 2af1e2f into develop Nov 10, 2025
40 checks passed
@klakhov klakhov deleted the kl/fix-user-requests branch November 10, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants