Use .Fatalf instead of .Errorf and return in function.tmpl#184
Closed
JeffFaer wants to merge 2 commits intocweill:developfrom
Closed
Use .Fatalf instead of .Errorf and return in function.tmpl#184JeffFaer wants to merge 2 commits intocweill:developfrom
JeffFaer wants to merge 2 commits intocweill:developfrom
Conversation
cweill
added a commit
that referenced
this pull request
Oct 21, 2025
This commit integrates improvements from several pending PRs and addresses key user feedback: ## Template Improvements (PR #184) - Use t.Fatalf() instead of t.Errorf() + return in subtests - Improves test ergonomics and reduces boilerplate - Updated golden test files to reflect new behavior ## Documentation Updates (PR #185, #180) - Document the -named flag for map-based table tests - Update installation from go get to go install (go get deprecated) - Update minimum Go version to 1.16 ## Use stdlib embed (PR #181) - Replace esc/go-bindata with Go 1.16+ embed package - Removes 834+ lines of generated code and 3rd party dependencies - Simplifies template loading and reduces maintenance burden - Convert symlinks in testify templates to real files for embed compatibility Breaking Changes: - Minimum Go version bumped from 1.6 to 1.16 (for embed support) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
cweill
added a commit
that referenced
this pull request
Oct 21, 2025
This commit integrates improvements from several pending PRs and addresses key user feedback: ## Template Improvements (PR #184) - Use t.Fatalf() instead of t.Errorf() + return in subtests - Improves test ergonomics and reduces boilerplate - Updated golden test files to reflect new behavior ## Documentation Updates (PR #185, #180) - Document the -named flag for map-based table tests - Update installation from go get to go install (go get deprecated) - Update minimum Go version to 1.16 ## Use stdlib embed (PR #181) - Replace esc/go-bindata with Go 1.16+ embed package - Removes 834+ lines of generated code and 3rd party dependencies - Simplifies template loading and reduces maintenance burden - Convert symlinks in testify templates to real files for embed compatibility Breaking Changes: - Minimum Go version bumped from 1.6 to 1.16 (for embed support) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Owner
|
Thank you so much for this PR! 🎉 This improvement has been integrated into v1.7.0. Generated tests now use Your contribution is part of the modernization effort that brought gotests back to life after 5 years. Really appreciate your patience and the quality of this PR! Check out the release: https://github.com/cweill/gotests/releases/tag/v1.7.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IntelliJ go plugin uses this library to generate test cases. This is one of my (relatively minor) annoyances. It tends to come up a lot in code reviews when I forget/don't change it to be
Fatalfinstead ofErrorf; return