Added ability to use external parameters and custom templates#90
Merged
cweill merged 13 commits intocweill:developfrom May 20, 2019
Merged
Added ability to use external parameters and custom templates#90cweill merged 13 commits intocweill:developfrom
cweill merged 13 commits intocweill:developfrom
Conversation
Owner
|
@a1305315624, I'll try to have a look this weekend. |
cweill
reviewed
Apr 7, 2019
Owner
cweill
left a comment
There was a problem hiding this comment.
@a1305315624: This mostly looks good to merge. Please see my comments.
Contributor
Author
|
I'll fix it at night |
cweill
requested changes
Apr 26, 2019
Owner
cweill
left a comment
There was a problem hiding this comment.
Looks good. Please resolve the comments, then we can merge.
cweill
approved these changes
May 13, 2019
Contributor
Author
|
What do I need to do about merge code? that is my first pull request. |
Owner
|
Sorry about that. It's now merged to master. |
cweill
added a commit
that referenced
this pull request
Jun 30, 2019
* Fix TravisCI and add go1.11 and go1.12 support (#94) * Fix function comments based on best practices from Effective Go (#89) Signed-off-by: CodeLingo Bot <[email protected]> * Added ability to use external parameters and custom templates (#90)
cweill
added a commit
that referenced
this pull request
Oct 21, 2025
Resolves #149 The -template_params flag was defined in main.go but never passed to the process.Options struct, making it non-functional. This was a bug introduced in PR #90. Changes: - Added TemplateParams field to process.Options struct - Updated main.go to pass *templateParams to process.Run() - Updated process.go to parse JSON from TemplateParams string - File-based params (-template_params_file) take precedence over string-based params (-template_params) if both are provided - Added proper error handling for invalid JSON The flag now works as intended: $ gotests -template_params '{"key":"value"}' -all file.go Thanks to @butuzov for identifying this issue and @cweill for the fix suggestion! 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff is designed so that gotests can be called by other tools using a custom template to generate data other than the test function. Fixes #96.
Please help to review, thank you.