Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 21, 2025. It is now read-only.

Conversation

@benni347
Copy link
Contributor

Hello,

With this pull request I implement a password generator so, new types can be added more easily. The main focus for this was to fix #3.
This pull request also contains the code to fix that issue.

@cyb3rko cyb3rko changed the title Password Generator Custom password generator + Alphaspace Type Apr 23, 2023
@cyb3rko
Copy link
Owner

cyb3rko commented Apr 23, 2023

Hi Benni,
thanks for your contribution. I will soon take a look at it.

I tend to replacing the input field for Password types with checkboxes of what to include into the password.
Then we would not need hardcoded types like Alphanumeric and Alphaspace.

Just like what Bitwarden does:

@cyb3rko
Copy link
Owner

cyb3rko commented Apr 23, 2023

But I'll first merge your PR and include it seperately I think.

@benni347
Copy link
Contributor Author

Do you want to implement check boxes only for the passwords or also for the passphrase?

@cyb3rko
Copy link
Owner

cyb3rko commented Apr 23, 2023

There are no settings for the passphrase generation except the length.
So check boxes would not really make sense there.

@benni347
Copy link
Contributor Author

There are settings for passphrases in the linux desktop client for bitwarden.
20230423_16h43m59s_grim

@cyb3rko
Copy link
Owner

cyb3rko commented Apr 23, 2023

Yeah, but Pazzword uses the nbvcxz passphrase generator, which does not support those settings.

@cyb3rko cyb3rko merged commit e26517c into cyb3rko:main Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addition of space character for password generator

2 participants