Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update to Pose node #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 31, 2023
Merged

Update to Pose node #205

merged 5 commits into from
May 31, 2023

Conversation

@ygoumaz
Copy link
Contributor

@ygoumaz ygoumaz commented May 31, 2023

cyberbotics/webots#5978 added the Pose node to Webots. The urdf2webots must be adapted to support this new feature.

@ygoumaz ygoumaz added the enhancement New feature or request label May 31, 2023
@ygoumaz ygoumaz self-assigned this May 31, 2023
@ygoumaz ygoumaz requested a review from omichel May 31, 2023 07:38
omichel
omichel requested changes May 31, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
It looks good to me, but I would not have renamed Human to HumanR2023b, instead, simply adding HumanR2023a should be sufficient and it should be removed when we release Webots R2023b.

@ygoumaz
Copy link
Contributor Author

ygoumaz commented May 31, 2023

Yes, I agree. However, we also have the HumanR2022a file, which allows to test the backwards compatibility, as we can specify a target Webots version (and convert files to older formats). So I don't think we will have to remove it.

I will update the name of the new one.

@ygoumaz ygoumaz requested a review from omichel May 31, 2023 09:45
omichel
omichel approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@ygoumaz ygoumaz merged commit 8900fee into develop May 31, 2023
@ygoumaz ygoumaz deleted the enhancement-transform-to-pose branch May 31, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omichel omichel omichel approved these changes

Assignees

@ygoumaz ygoumaz

Labels

enhancement New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ygoumaz @omichel