Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@DivadNojnarg
Copy link
Collaborator

@DivadNojnarg DivadNojnarg commented Oct 4, 2025

@nbenn:

Still wip but you can test on your side...

  • Now you benefit from input$dock_initialized to have correct timing.

  • New input[["<dock_ID>_restored"]].

  • New input[["<dock_ID>_panel-to-add"]].

  • You can also initialize a dock with nothing by callingdock_view().

  • I introduced a proxy object for all add_panel(), ... methods as well as get_dock() and friends.

  • New dock plugin API to control the add_tab and remove tab behaviors in a cleaner/safer way (instead of passing a basic list that had no semantic).

  • add_panel() don't check for id uniqueness server side. This has been moved UI side.

  • See news.md

  • Update some tests

  • Provide fine-grained inputs that are a subset of input$dock_state.

@DivadNojnarg
Copy link
Collaborator Author

@nelstevens I think this PR is also a great place to remove move_group. Playing with this package for few months, I realise users are not supposed to know the group ids, as they are assigned by dockview. When you start to move things around, you can easily lose track of those groups. With the new API, we have a group/panel mapping available with the proxy data, but this is more meant to be used by internal functions rather than by users. So we can just use move_group2 that works with panel IDs, where user have control over, and rename it to move_group. Do you have any concerns?

@DivadNojnarg
Copy link
Collaborator Author

Leaving some days and discussing with @MikeJohnPage, we believe the approach is a bit too heavy on the R side, complex to maintain and feels a bit "off". We will go for another approach where checks are made by JS and relevant warning issued in the JS console and optionally as shiny notifications (shiny dev mode).

@DivadNojnarg
Copy link
Collaborator Author

Layout helpers will be managed in another PR, as this one brings significant amount of changes.

@DivadNojnarg
Copy link
Collaborator Author

Thanks again @nbenn and @MikeJohnPage for the feedback on this one.

@DivadNojnarg DivadNojnarg merged commit 7a115bc into main Oct 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant