-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor api #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor api #54
Conversation
|
@nelstevens I think this PR is also a great place to remove |
|
Leaving some days and discussing with @MikeJohnPage, we believe the approach is a bit too heavy on the R side, complex to maintain and feels a bit "off". We will go for another approach where checks are made by JS and relevant warning issued in the JS console and optionally as shiny notifications (shiny dev mode). |
|
Layout helpers will be managed in another PR, as this one brings significant amount of changes. |
|
Thanks again @nbenn and @MikeJohnPage for the feedback on this one. |
@nbenn:
Still wip but you can test on your side...
Now you benefit from
input$dock_initializedto have correct timing.New
input[["<dock_ID>_restored"]].New
input[["<dock_ID>_panel-to-add"]].You can also initialize a dock with nothing by calling
dock_view().I introduced a proxy object for all
add_panel(), ... methods as well asget_dock()and friends.New dock plugin API to control the add_tab and remove tab behaviors in a cleaner/safer way (instead of passing a basic list that had no semantic).
add_panel()don't check for id uniqueness server side. This has been moved UI side.See news.md
Update some tests
Provide fine-grained inputs that are a subset of input$dock_state.