Fix #17 and #20 #21
Merged
Fix #17 and #20 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to check this one @nelstevens. It is quite big but overall this is about adding more checks, testing and also fixing 2 existing issues. |
nelstevens
approved these changes
Apr 16, 2025
R/move_panel.R
Outdated
| #' @param index Panel index. If panels belong to the same group, you can use index to move the target | ||
| #' panel at the desired position. | ||
| #' panel at the desired position. When group is left NULL, index must be passed and cannot exceed the | ||
| #' total number of panel or be negative. |
There was a problem hiding this comment.
typo: total number of panels ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #17 and #20.