Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@DivadNojnarg
Copy link
Collaborator

Fix #22, Fix #23

@DivadNojnarg
Copy link
Collaborator Author

@nelstevens This PR provides a way to save the state and restore a dock from a saved state. Part of this state is also used to check panel ids, which replaces our custom input. I made also some adjustments here and there in the JS side by removing some events that are no longer needed. (Long run I'd like to get rid of jQuery).

There are some breaking changes (maybe not for your PR #18). We also fix an issue where panel id is now prefixed by the dock id to avoid duplicated html elements.

Feel free to check next week. One test fails but this is some random issue with chromote I can't replicate.

Caused by error:
! Chromote: timed out waiting for response to command Page.navigate
Backtrace:

@DivadNojnarg DivadNojnarg marked this pull request as ready for review April 18, 2025 07:39
@DivadNojnarg
Copy link
Collaborator Author

Also fixed some issues with module to account for the namespace + renamed parameter and export the api object to make it accessible from JS.

@DivadNojnarg DivadNojnarg merged commit dd23ed1 into main Apr 22, 2025
6 of 8 checks passed
@DivadNojnarg DivadNojnarg deleted the f-22-serialise branch July 9, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Bug: duplicated ids Feat: serialise/deserialize a dock

1 participant