libicalvcard: escape unescaped backslash at end of value #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brong
reviewed
Feb 18, 2025
brong
approved these changes
Feb 18, 2025
Fixes a bug where an unescaped backslash at the end of a value caused the vCard parser attempt to free the multi-valued TEXT buffer, even if that had not been allocated. Rather than rejecting a TEXT property with a trailing backslash as invalid, the parser now pads that backslash with a second backslash, preserving the backslash character effectively.
1ec8bbb to
d79bca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where an unescaped backslash at the end of a value caused the vCard parser attempt to free the multi-valued TEXT buffer, even if that had not been allocated.
Rather than rejecting a TEXT property with a trailing backslash as invalid, the parser now pads that backslash with a second backslash, preserving the backslash character effectively.