match cna chart colors with oncoprint and adjust label colors according to slice brightness #4750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to slice brightness
alisman
reviewed
Oct 9, 2023
| : d.count.toLocaleString(); | ||
| } | ||
|
|
||
| @computed |
There was a problem hiding this comment.
it doesn't make sense to make this a computed property because it's returning a callback which will be executed outside the scope of mobx's optimization. you should make this a bound method of this class instead of a computed getter. the cost of deriving the color for a handful of piechart slices is negligible.
There was a problem hiding this comment.
the importance of this comment is mostly just to make sure you understand what the computed decorator does. you can read about it in mobx documentation if necessary.
There was a problem hiding this comment.
haynescd
pushed a commit
that referenced
this pull request
Nov 15, 2023
#4750) * match cna chart colors with oncoprint and adjust label colors according to slice brightness * fix end to end tests on study view page * update pie charts @computed to @autoBind --------- Co-authored-by: Qi-Xuan Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix cBioPortal/cbioportal#10367