Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement Custom Tabs mechanism for Study View #4776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 8, 2023
Merged

Implement Custom Tabs mechanism for Study View #4776

merged 5 commits into from
Dec 8, 2023

Conversation

pvannierop
Copy link
Contributor

@pvannierop pvannierop commented Nov 10, 2023 •
edited
Loading

This PR will extend the Custom Tabs mechanism (currently implemented for results view, patient view and comparison view) to study view. Elements include are:

  • Read tabs configuration from tab configs labeled with STUDY_PAGE.
  • Attach the Study View Page Store to the window object.
  • Attach the onMobxPromise function to the window object. This allows the javascript to trigger and await the MobX promisses of the StudyViewPageStore.

@pvannierop pvannierop requested a review from alisman November 10, 2023 14:45
@pvannierop pvannierop force-pushed the feature/custom-tabs-in-studyview branch from 61cad3b to 3d45b2a Compare November 10, 2023 14:56
@pvannierop
Expose StudyViewPageStore to window object
3adfd59 
Allows custom tabs in study view to access store data.
@pvannierop
Expose onMobxPromise function to windows object
ccc7a86 
Needed for use in custom tab javascript files
@pvannierop
Render custom tabs on Study View Page
332ffac
@pvannierop pvannierop force-pushed the feature/custom-tabs-in-studyview branch from 3d45b2a to a9d8530 Compare November 29, 2023 11:32
@pvannierop pvannierop self-assigned this Nov 29, 2023
@inodb inodb added the devops label Dec 4, 2023
@pvannierop pvannierop force-pushed the feature/custom-tabs-in-studyview branch from d8ca8e2 to 15f108e Compare December 8, 2023 10:54
@alisman alisman merged commit 100f4b9 into cBioPortal:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alisman alisman alisman approved these changes

Assignees

@pvannierop pvannierop

Labels

devops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pvannierop @alisman @inodb