Add table visualisation for categorical values #5012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a5a9793 to
e4e624d
Compare
|
@inodb Can you please review the change or suggest who should I ask for review? |
- Change logic related to showing checkboxes leaving only show N/A for table - Rename "Plot Type" to "Visualisation Type"
inodb
reviewed
Jan 30, 2025
There was a problem hiding this comment.
@pozhidaevak everything here looks great - thank you so much! Just need to update visualisation -> visualization for American spelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cBioPortal/cbioportal#10900
Change description:
Tests
I haven't added tests as I'm new to the project and not sure which ones are better to add. Will appreciate any guidance
Screenshots
Before
After