Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

rishisulakhe
Copy link
Contributor

Fix cBioPortal/cbioportal#11024

Describe changes proposed in this pull request:

  • Fix legend to dynamically update with filtered categories in Plots tab

Checks

  • [ ✓] Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • [ ✓] The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • [✓ ] Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

Screenshot 2025-03-13 224224

Screenshot 2025-03-13 205617

@netlify
Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 8ad8cda
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/67d316e2ee50ff00088026c1
😎 Deploy Preview https://deploy-preview-5130.preview.cbioportal.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rishisulakhe
Copy link
Contributor Author

rishisulakhe commented Mar 13, 2025

Hello @alisman @inodb
Please take a look at this PR and suggest any required changes
Thankyou.

@alisman
Copy link
Collaborator

alisman commented May 14, 2025

@rishisulakhe FYI, i'm resolving some issues with screenshots. make sure to rebase your branch. i'll probably be making more updates

@alisman alisman merged commit 1578ef7 into cBioPortal:master May 15, 2025
14 of 16 checks passed
@alisman alisman changed the title feat : Update legend with filtered categories in Plots tab Update legend with filtered categories in Plots tab May 15, 2025
@rishisulakhe rishisulakhe deleted the i-11024 branch May 16, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plots tab legend by default shows all possible values for the category used to color by

2 participants