Stabilize flaky unprofiled samples oncoprint and breadcrumbs tests #5161
Conversation
8bcfca9 to
241de48
Compare
| function runResultsTestSuite(prefix, options = {}) { | ||
| it(`${prefix} render the oncoprint`, async function() { | ||
| await waitForOncoprint(); | ||
| await (await getElement('body')).moveTo({ xOffset: 0, yOffset: 0 }); // move mouse out of the way |
There was a problem hiding this comment.
@gblaih seems like this is redundant with checkElementWithMouseDisabled, no? so i mean, i just question whether this would really stabilize it give that we are already trying the same thing and it doesn't seem to work?
There was a problem hiding this comment.
yea I would think that checkElementWithMouseDisabled would remove the mouse effects the same way moving the mouse away would. but when testing I haven't ran into issues moving the mouse away. maybe checkElementWithMouseDisabled somehow is not reliable in clearing existing mouse effects
There was a problem hiding this comment.
we also have an existing function checkOncoprintElement that clears hover effects before it calls checkElementWithMouseDisabled so it may be known thatcheckElementWithMouseDisabled doesn't fully fix hover effects. maybe we can use this function instead
Excluding unprofiled samples oncoprint test is flaky due to mouse hovering effects. This attempts to stabilize that. Breadcrumbs test is still flaky, potentially due to reset charts button not being clicked. Added brief pause to let add charts button contents load.