Rename table header to 'Data Types' and remove 'Molecular Profile' #5210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdd0c1e to
77ae193
Compare
AnukulPK
approved these changes
Jun 12, 2025
alisman
reviewed
Jun 12, 2025
|
|
||
| export enum MultiSelectionTableColumnKey { | ||
| GENE = 'Gene', | ||
| MOLECULAR_PROFILE = 'Molecular Profile', |
There was a problem hiding this comment.
@viveak910 this seems risky. the enum is named "...key" which suggests perhaps it is used for logical purposes somewhere. If in fact it is only a label, lets rename the enum
There was a problem hiding this comment.
otherwise, maybe we can create an override or something on the component
alisman
reviewed
Jun 12, 2025
| {columnKey} | ||
| </div> | ||
| ); | ||
| return <></>; |
There was a problem hiding this comment.
@viveak910 this is a more surgical fix i think
There was a problem hiding this comment.
Got it, thanks @alisman ! That makes sense — a more surgical fix indeed. Appreciate the clarity 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#11579
What does this PR do?
Integration Tests
✅ Integration tests passed successfully after this change with no issues.
Checks