Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

TJMKuijpers
Copy link
Contributor

@TJMKuijpers TJMKuijpers commented Feb 20, 2025

There is a bug that prevents the user to customize the oncoprint clinical tracks and custom sample color. User can upload a json file as stated in the documentation but this is broken. For reference, the documentation mentions that oncoprint clinical tracks can be set by:
oncoprint.clinical_tracks.config_json=classpath:/oncoprint-default-tracks.json

The current bug:
oncoprint_clinical_tracks_config_json is set by:
oncoprint_clinical_tracks_config_json("oncoprint.clinical_tracks.config_json", null)
and the custom sample colors by:
skin_patient_view_custom_sample_type_colors_json("skin.patient_view.custom_sample_type_colors_json", null)

In the function getPropertyValue the variable names do not match:

case "frontendConfigOverride":
            case "query_sets_of_genes":
            case "skin.patient_view.custom_sample_type_colors_json":
            case "oncoprint.clinical_tracks.config_json":
            case "download_custom_buttons_json":
                return readFile(propertyValue);`

and it will return the propertyValue:

default:
      return propertyValue;

@sonarqubecloud
Copy link

@TJMKuijpers TJMKuijpers marked this pull request as ready for review February 21, 2025 14:57
@dippindots dippindots requested a review from onursumer February 21, 2025 15:52
Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alisman alisman merged commit 22dd16f into cBioPortal:master Feb 25, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants