Update the names for oncoprint tracks and custom sample color #11400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug that prevents the user to customize the oncoprint clinical tracks and custom sample color. User can upload a json file as stated in the documentation but this is broken. For reference, the documentation mentions that oncoprint clinical tracks can be set by:
oncoprint.clinical_tracks.config_json=classpath:/oncoprint-default-tracks.jsonThe current bug:
oncoprint_clinical_tracks_config_json is set by:
oncoprint_clinical_tracks_config_json("oncoprint.clinical_tracks.config_json", null)and the custom sample colors by:
skin_patient_view_custom_sample_type_colors_json("skin.patient_view.custom_sample_type_colors_json", null)In the function
getPropertyValuethe variable names do not match:and it will return the propertyValue: