Fix logout confirmation issue for saml_plus_basic #11469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
745cdee to
2196e93
Compare
2196e93 to
5c46293
Compare
|
haynescd
approved these changes
Mar 31, 2025
Comment on lines
+86
to
+96
| LogoutFilter basicLogoutFilter = new LogoutFilter( | ||
| basicLogoutSuccessHandler, | ||
| (request, response, authentication) -> { | ||
| if (authentication != null && authentication.getPrincipal() instanceof UserDetails) { | ||
| // Clear the authentication | ||
| SecurityContextHolder.clearContext(); | ||
| // Invalidate the session | ||
| request.getSession(false).invalidate(); | ||
| } | ||
| } | ||
| ); |
There was a problem hiding this comment.
You don't have to change this but next time I would just wrap this in a new class to keep the config as simple as possible... BasicLogoutFilter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11428
Describe changes proposed in this pull request: