Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add property to set default view oncoprint #11503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

add property to set default view oncoprint #11503

merged 1 commit into from
Aug 6, 2025

Conversation

TJMKuijpers
Copy link
Contributor

The FrontendPropertiesServiceImpl.java is missing the property to set the default view of oncoprint (sample vs patient).
Added the following line:
oncoprint_defaultview("oncoprint.defaultview", null),

@alisman
Copy link
Contributor

alisman commented Apr 21, 2025

@TJMKuijpers there is a new sonar issue introduced. can you fix it?

@TJMKuijpers
Copy link
Contributor Author

@alisman sure, I will have a look at the sonarcloud error

@TJMKuijpers TJMKuijpers force-pushed the add-missing-frontend-config branch from a0b552e to 8815249 Compare April 25, 2025 12:29
@alisman alisman force-pushed the add-missing-frontend-config branch from 8815249 to 54fd80f Compare May 5, 2025 17:50
@TJMKuijpers TJMKuijpers force-pushed the add-missing-frontend-config branch from 54fd80f to d57c82a Compare May 8, 2025 09:07
@TJMKuijpers TJMKuijpers marked this pull request as ready for review May 8, 2025 14:34
@alisman
Copy link
Contributor

alisman commented May 12, 2025

@TJMKuijpers looks like there's a conflict now?

@TJMKuijpers TJMKuijpers force-pushed the add-missing-frontend-config branch 2 times, most recently from 22835ae to bb29f05 Compare May 19, 2025 09:00
@alisman
Copy link
Contributor

alisman commented May 19, 2025

@TJMKuijpers did you fix the solar issue? it still seems to report 1 problem

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TJMKuijpers
Copy link
Contributor Author

@alisman
I looked at the sonar issue but I'm not sure how/if the issue should be resolved:

Sonar does say that we should:

  1. Rename oncoprint_defaultview to oncoprint_default_view
  2. Capitalize oncoprint_default_view to ONCOPRINT_DEFAULT_VIEW

I think all the definitions in FrontendPropertiesServiceImpl.java are formatted like they are in application.properties (for example, we also don't separate patientview in skin_patientview_show_mskcc_slide_viewer). But I can change the name to oncoprint_default_view and create a frontend PR (since in the frontend we are looking for oncoprint_defaultview). I don't think that capitalizing the parameter is in line with the rest of the code.

@TJMKuijpers TJMKuijpers force-pushed the add-missing-frontend-config branch from 050345f to 53e7cb7 Compare July 17, 2025 09:00
@TJMKuijpers TJMKuijpers force-pushed the add-missing-frontend-config branch from 53e7cb7 to cc160af Compare August 4, 2025 07:57
@TJMKuijpers
Update FrontendPropertiesServiceImpl
6d1a06a 
Resolve sonarcloud issue

Rebase on master
@TJMKuijpers TJMKuijpers force-pushed the add-missing-frontend-config branch from cc160af to 6d1a06a Compare August 4, 2025 14:10
@TJMKuijpers TJMKuijpers requested a review from dippindots August 5, 2025 14:39
dippindots
dippindots approved these changes Aug 5, 2025
View reviewed changes
Copy link
Collaborator

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TJMKuijpers @alisman I think this PR looks good. I can't access Sonar's comment for some reason, but if it's only related to capitalization and naming, I believe it's fine as is.

@dippindots dippindots merged commit fd4fbbe into cBioPortal:master Aug 6, 2025
21 checks passed
i-am-leslie pushed a commit to i-am-leslie/cbioportal that referenced this pull request Aug 13, 2025
@TJMKuijpers @i-am-leslie
Update FrontendPropertiesServiceImpl (cBioPortal#11503)
bcbbdda 
Resolve sonarcloud issue

Rebase on master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dippindots dippindots dippindots approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TJMKuijpers @alisman @dippindots