Optimize SVG output #219
Merged
Optimize SVG output #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate tags are no longer generated if tags have no content
|
nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this great project!
Description
This PR removes duplicate tags if there is no content in them. It also removes the
xmlnsattribute from thetexttags because it's not needed AFAIK. In total, the SVG size is roughly halved.File Comparison
This is the original (formatted) file
and this is the optimized (formatted) file
Both are formatted to make them easier to compare (after saving), but nothing has been changed after the generation except for whitespace.
Also, ignore the 2021-10-12 vs 2021-10-13 date difference. That might be because I'm using slightly different go dependencies, or I can't generate both images at exactly the same time.
P.S.: The way Inkscape optimizes SVGs is also interesting, but this exceeds my basic knowledge of SVGs. See this file for comparison
