I don't like to depend on a toString implementation, maybe there's something like Collectors.joining from java 8 (http://docs.oracle.com/javase/8/docs/api/java/util/stream/Collectors.html#joining-java.lang.CharSequence-) in guava api that we can use?

Sure, there's a Guava utility that joins collections. I was just keeping to the original implementation, but I don't mind switching one bit.

I think you improve that now :-)

Chico Sokol

On Mon, Nov 3, 2014 at 3:59 PM, monitorjbl [email protected] wrote:

In src/main/java/org/mamute/search/SolrQuestionIndex.java:

•   String answer = null;
  

•   List<String> responses = new ArrayList<>();
  

•   for (Answer a : q.getAnswers()) {
  

•       if (a.isSolution()) {
  

•           answer = a.getDescription();
  

•       } else {
  

•           responses.add(a.getDescription());
  

•       }
  

•   }
  

•   if (answer != null) {
  

•       doc.addField("answer", answer);
  

•   }
  

•   if (responses.size() > 0) {
  

•       doc.addField("responses", responses.toString().replace("[", "").replace("]", ""));
  

•   }
  

Sure, there's a Guava utility that joins collections. I was just keeping
to the original implementation, but I don't mind switching one bit.

—
Reply to this email directly or view it on GitHub
https://github.com/caelum/mamute/pull/114/files#r19751084.