-
Notifications
You must be signed in to change notification settings - Fork 151
Moderators can delete users #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identation ):
|
Well, as I said at the other pr, I prefer logic deletion over physical deletion. Its easier to implement and you can always rollback |
|
But this implementation is using soft deletion: https://github.com/csokol/mamute/blob/deleting-users/src/main/java/org/mamute/model/User.java#L50 |
|
Even this query? |
|
Well, in this case I had to delete the data from the relationship table because hibernate was not so smart to ignore logically deleted comments when querying answers/questions joined with its comments. I can try to add |
|
Well, I don't know if it will be hard or not to ignore all of them, but if we used left joins they should be ignored automatically if their relationships are, right? |
|
They can't be ignored on left joins since the row still exists after deletion and hibernate is not smart enough to add |
|
Hi Leo, I removed that query from CommentDAO and added the logic to ignore deleted questions. I'm merging this one! |
No description provided.