Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix comment notification mail #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2016
Merged

Fix comment notification mail #230

merged 2 commits into from
Feb 13, 2016

Conversation

@xdarklight
Copy link
Contributor

The first commit fixes an exception when sending the comment notification mail:

java.lang.RuntimeException: java.lang.IllegalArgumentException: Subject not defined for email template : comment_notification_mail
        at br.com.caelum.vraptor.simplemail.template.DefaultTemplateMail.prepareEmail(DefaultTemplateMail.java:99)
        at br.com.caelum.vraptor.simplemail.template.DefaultTemplateMail.to(DefaultTemplateMail.java:66)
        at org.mamute.notification.NotificationMailer.buildEmail(NotificationMailer.java:72)
        at org.mamute.notification.NotificationMailer.send(NotificationMailer.java:51)
        at org.mamute.notification.NotificationManager$SendNotifications$1.insideRequest(NotificationManager.java:84)
        at org.mamute.notification.NotificationManager$SendNotifications$1.insideRequest(NotificationManager.java:1)
        at org.mamute.components.CDIFakeRequestProvider.insideRequest(CDIFakeRequestProvider.java:30)
        at org.mamute.notification.NotificationManager$SendNotifications.run(NotificationManager.java:77)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalArgumentException: Subject not defined for email template : comment_notification_mail
        at br.com.caelum.vraptor.simplemail.template.DefaultTemplateMail.prepareEmail(DefaultTemplateMail.java:92)
        ... 10 more

The second commit fixes the subject of the same email.

@xdarklight
Add translations for the comment_notification_mail subject
1f1f869 
The subject is automatically generated by vraptor-simplemail by taking
the name of the email template as message key.
@xdarklight
Let vraptor-simplemail handle the subject of notification mails
ed7d872 
By default vraptor-simplemail uses the name of the email template as
message key. It also allows appending message parameters which have to
be given when specifying the template.
This fixes the subject of comment_notification_mail mails.
@felipeweb
Copy link
Contributor

@csokol ok

felipeweb added a commit that referenced this pull request Feb 13, 2016
@felipeweb
Merge pull request #230 from xdarklight/fix-comment-notification-mail
69568c2 
Fix comment notification mail
@felipeweb felipeweb merged commit 69568c2 into caelum:master Feb 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xdarklight @felipeweb