Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GH1106: Multiple values passed to WithProperty are overridden #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

GH1106: Multiple values passed to WithProperty are overridden #2110

wants to merge 3 commits into from

Conversation

mschlaffer
Copy link

Changed MSBuildExtension's WithProperty to forward multiple parameters as a comma separated list surrounded by quotes. Single parameter behavior is unchanged to before and does not have the added quotes.

This should fix #1106. Check the comments there for more details.

@dnfclas
Copy link

dnfclas commented Apr 2, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@devlead devlead force-pushed the feature/gh-1106-multiple-values-withproperty branch from 770732d to 95e2547 Compare March 22, 2019 00:35
@augustoproiete augustoproiete changed the title GH1106 Multiple values passed to WithProperty are overridden GH-1106: Multiple values passed to WithProperty are overridden Feb 28, 2021
@augustoproiete augustoproiete force-pushed the feature/gh-1106-multiple-values-withproperty branch from 95e2547 to 0a5aa03 Compare March 3, 2021 03:32
@augustoproiete augustoproiete force-pushed the feature/gh-1106-multiple-values-withproperty branch from 0a5aa03 to 6f748a0 Compare October 10, 2021 00:43
pascalberger
pascalberger requested changes Oct 17, 2021
View reviewed changes
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caopi Thanks you for your contribution and sorry for the late answer. We're now at a point where we can change this behavior in an upcoming release.

We would prefer to use semicolon instead of comas for separating the values as mentioned in the comment. Additionally there should be some integration tests for this, which makes sure that this actually works together with MsBuild.

Are you still in a position to continue with this PR or prefer for someone else to take over?

@mschlaffer
Copy link
Author

Hey Pascal, sorry for the late reply as well. I've quickly accepted your suggestion of course, but I would prefer if someone else could take over the integration test part. Haven't worked with C# and Cake in a while nowadays and don't have a lot of time to commit to this right now, sorry!

@gep13 gep13 changed the title GH-1106: Multiple values passed to WithProperty are overridden GH1106: Multiple values passed to WithProperty are overridden Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pascalberger pascalberger pascalberger requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@gep13 gep13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple values passed to WithProperty are overridden

6 participants

@mschlaffer @dnfclas @pascalberger @augustoproiete @gep13 @devlead