perf: rename eventTypes.heavy to eventTypesHeavy #24630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-brydon
commented
Oct 22, 2025
Comment on lines
-56
to
-61
| eventTypes: mergeRouters( | ||
| eventTypesRouter, | ||
| router({ | ||
| heavy: heavyEventTypesRouter, | ||
| }) | ||
| ), |
Member
Author
There was a problem hiding this comment.
MergeRouter kills our types when looking at a trace - easier to do this instead
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
apps/web/app/_trpc/trpc-client.ts
Outdated
| // - viewer.me - 2 segment paths like this are for logged in requests | ||
| // - viewer.public.i18n - 3 segments paths can be public or authed | ||
| // - viewer.eventTypes.heavy.create - 4 segments paths for heavy sub-router | ||
| // - viewer.eventTypesHeavy.create - 3 segment paths for flattened heavy router |
Contributor
There was a problem hiding this comment.
Delete this line. The line above is for 3 segments already
apps/web/app/_trpc/trpc-client.ts
Outdated
| if (parts.length == 2) { | ||
| endpoint = parts[0] as keyof typeof links; | ||
| path = parts[1]; | ||
| } else if (parts.length >= 3 && parts[2] === "heavy") { |
Contributor
There was a problem hiding this comment.
Delete this if. No longer needed
packages/trpc/react/trpc.ts
Outdated
| // - viewer.me - 2 segment paths like this are for logged in requests | ||
| // - viewer.public.i18n - 3 segments paths can be public or authed | ||
| // - viewer.eventTypes.heavy.create - 4 segments paths for heavy sub-router | ||
| // - viewer.eventTypesHeavy.create - 3 segment paths for flattened heavy router |
Contributor
There was a problem hiding this comment.
Delete this line as the 3 segment description above works
Contributor
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/trpc/react/trpc.ts">
<violation number="1" location="packages/trpc/react/trpc.ts:30">
The heavy router guard was removed, but ENDPOINTS still exposes only "eventTypes/heavy", so viewer.eventTypesHeavy.* now resolves to links["eventTypesHeavy"] === undefined and these tRPC calls will fail at runtime.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Contributor
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/web/app/_trpc/trpc-client.ts">
<violation number="1" location="apps/web/app/_trpc/trpc-client.ts:26">
Heavy router calls now get sent to the generic eventTypes endpoint instead of /eventTypes/heavy, so operations like viewer.eventTypesHeavy.update will fail.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
keithwillcode
approved these changes
Oct 22, 2025
keithwillcode
requested changes
Oct 22, 2025
Contributor
keithwillcode
left a comment
There was a problem hiding this comment.
@sean-brydon Since this is going to now hit /api/trpc/eventTypesHeavy, you need to move that [trpc].ts file in app/web/pages/api/trpc/eventTypes/heavy/[trpc].ts
Contributor
E2E results are ready! |
anikdhabal
requested changes
Oct 22, 2025
The WorkflowType enum should be imported from @calcom/prisma/enums rather than @calcom/prisma/client. This was causing integration tests to fail with 'Cannot read properties of undefined (reading EVENT_TYPE)' because the enum wasn't being properly exported from the client. This fixes the remaining integration test failures after the Prisma 6.16 upgrade. Co-Authored-By: [email protected] <[email protected]>
keithwillcode
approved these changes
Oct 23, 2025
KartikLabhshetwar
pushed a commit
to KartikLabhshetwar/cal.com
that referenced
this pull request
Oct 25, 2025
* Rename eventTypes.heavy to eventTypesHeavy * Update eventTypes lib types * Remove trpc and trpc client heavy resolve endpoint * Update shared file * Fix comments * Rename path * Fix wait for URL path * Fix API endpoint in event-types.e2e.ts test * fix: Import WorkflowType from enums instead of client The WorkflowType enum should be imported from @calcom/prisma/enums rather than @calcom/prisma/client. This was causing integration tests to fail with 'Cannot read properties of undefined (reading EVENT_TYPE)' because the enum wasn't being properly exported from the client. This fixes the remaining integration test failures after the Prisma 6.16 upgrade. Co-Authored-By: [email protected] <[email protected]> --------- Co-authored-by: Keith Williams <[email protected]> Co-authored-by: Anik Dhabal Babu <[email protected]> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the mergeRotuer which after running a tsc trace - appears to be generating some nasty types. In favour of using a seperate router for this