Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@matthewpeterkort
Copy link
Collaborator

@matthewpeterkort matthewpeterkort commented Jul 29, 2024

adds grip to ohsu-develop see ACED-IDP/aced_etl_pod#36 for testing instructions

@quinnwai quinnwai self-requested a review July 29, 2024 19:32
Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments, most of them are for my understanding.

Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal TODO comments, mostly a main one on scope etc

quinnwai
quinnwai previously approved these changes Aug 22, 2024
Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing completed, see details on ticket here, lgtm

Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewpeterkort matthewpeterkort merged commit 92153ca into ohsu-develop Sep 12, 2024
@matthewpeterkort matthewpeterkort deleted the feature/grip branch September 12, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants