command -v instead of command which, fixes #462 #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #462 by replacing the use of "command which" with the more reliable and standard "command -v" to locate the mcfly binary.
- Replaces "command which mcfly" with "command -v mcfly" to improve binary lookup reliability.
Comments suppressed due to low confidence (1)
mcfly.fish:23
- The replacement of 'command which mcfly' with 'command -v mcfly' correctly addresses the issue of unreliable binary lookup and should work consistently across environments.
set -q MCFLY_PATH; or set -l MCFLY_PATH (command -v mcfly)
praveenperera
approved these changes
Jun 18, 2025
Collaborator
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command -v instead of command which, fixes #462