Fix clippy lint #464
Merged
Fix clippy lint #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a Clippy lint by replacing manual index underflow checks with saturating_sub for safer subtraction.
- Simplified boundary check to use
count.saturating_sub(1)instead of a manualif count >= 1guard. - Corrected indexing logic to prevent potential underflow in
vec[...]lookups.
| for &(count, (offset, _)) in vec.iter().rev() { | ||
| if count <= self.cursor { | ||
| if !found_word && (vec[if count >= 1 { count - 1 } else { 0 }].1).1 == " " { | ||
| if !found_word && (vec[count.saturating_sub(1)].1).1 == " " { |
There was a problem hiding this comment.
[nitpick] Consider destructuring the tuple to avoid nested .1 accesses and improve readability. For example:
let (_, (prev_offset, prev_char)) = vec[count.saturating_sub(1)];
if !found_word && prev_char == " " {
// ...
}
Suggested change
| if !found_word && (vec[count.saturating_sub(1)].1).1 == " " { | |
| let (_, (_, prev_char)) = vec[count.saturating_sub(1)]; | |
| if !found_word && prev_char == " " { |
Collaborator
Author
|
Hey @cantino sorry I haven't been active maintaining, but I'd like to be more active. PRs like this do you want me to wait for your review? Or just merge it? |
Owner
|
Really appreciate it @praveenperera! For this kind of small change, go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.