Fix range check with negative scalings #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7358272096
💛 - Coveralls |
andlaus
reviewed
Dec 28, 2023
andlaus
reviewed
Dec 28, 2023
src/cantools/database/can/message.py
Outdated
| if scaling: | ||
| scaled_value = signal_value | ||
| else: | ||
| if signal.conversion.choices and signal_value in signal.conversion.choices: |
There was a problem hiding this comment.
that condition probably must go one level up (scaled values can also be enums)
There was a problem hiding this comment.
That's true, fixed.
andlaus
approved these changes
Dec 29, 2023
|
all cool now, let's get that merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #636