perf: Cache Signal Codecs #756
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18507065384Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my organization, we often add many "duplicate" DBC's to a database to build a larger database. We found an optimization to cache the work done by
create_encode_decode_formatsand key it with the signal, so that in the event of adding "duplicate" signals, we are not doing work that has already been done.This change showed an decrease in runtime of at least 16% when calling
self.refresh()in many cases, but this scales with how many "duplicate" signals you are adding to a given database.I don't really love the
_signal_cache_keyfunction as it really just makes more sense to add ahashfunction to theDataandSignalclasses respectively IMO but I am not a maintainer so would appreciate guidance in the right direction there.