Thanks to visit codestin.com
Credit goes to github.com

Skip to content

No more room for ambiguity in the getIndex and getIndexReader methods #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lintool merged 5 commits into from
Aug 19, 2025
Merged

No more room for ambiguity in the getIndex and getIndexReader methods #2929

lintool merged 5 commits into from
Aug 19, 2025

Conversation

@JJGreen0
Copy link
Contributor

@JJGreen0 JJGreen0 commented Aug 19, 2025

If a prebuilt label and a local path both exist, we no longer choose one over the other by default and instead inform the user.

Looks like this:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running io.anserini.rerank.GenerateRerankerRequestsTest
2025-08-18 18:10:09,578 INFO  [main] rerank.GenerateRerankerRequests (GenerateRerankerRequests.java:218) - Generating reranker requests with raw documents from index: src/test/resources/prebuilt_indexes/raw-beir-collection1-index
2025-08-18 18:10:10,024 INFO  [main] rerank.GenerateRerankerRequests (GenerateRerankerRequests.java:177) - Generating reranker requests with raw topics from: src/test/resources/sample_topics/acl_topics.tsv
2025-08-18 18:10:10,153 INFO  [main] rerank.GenerateRerankerRequests (GenerateRerankerRequests.java:218) - Generating reranker requests with raw documents from index: src/test/resources/prebuilt_indexes/raw-beir-collection1-index
2025-08-18 18:10:10,158 INFO  [main] rerank.GenerateRerankerRequests (GenerateRerankerRequests.java:177) - Generating reranker requests with raw topics from: src/test/resources/sample_topics/acl_topics.tsv
2025-08-18 18:10:10,202 INFO  [main] rerank.GenerateRerankerRequests (GenerateRerankerRequests.java:218) - Generating reranker requests with raw documents from index: src/test/resources/prebuilt_indexes/lucene9-index.sample_docs_trec_collection2
2025-08-18 18:10:10,212 INFO  [main] rerank.GenerateRerankerRequests (GenerateRerankerRequests.java:177) - Generating reranker requests with raw topics from: src/test/resources/sample_topics/acl_topics.tsv
2025-08-18 18:10:10,224 INFO  [main] rerank.GenerateRerankerRequests (GenerateRerankerRequests.java:218) - Generating reranker requests with raw documents from index: src/test/resources/prebuilt_indexes/raw-beir-collection1-index
2025-08-18 18:10:10,229 INFO  [main] rerank.GenerateRerankerRequests (GenerateRerankerRequests.java:167) - Generating reranker requests with raw topics from: CACM
[ERROR] Tests run: 7, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 1.627 s <<< FAILURE! - in io.anserini.rerank.GenerateRerankerRequestsTest
[ERROR] io.anserini.rerank.GenerateRerankerRequestsTest.testParseTopics  Time elapsed: 0.007 s  <<< ERROR!
java.lang.IllegalArgumentException: Ambiguous index reference "cacm": both a prebuilt index label and a local path exist. Please disambiguate by specifying a full local path or removing/renaming the local directory.
        at io.anserini.rerank.GenerateRerankerRequests.getIndexReader(GenerateRerankerRequests.java:205)
        at io.anserini.rerank.GenerateRerankerRequests.<init>(GenerateRerankerRequests.java:92)
        at io.anserini.rerank.GenerateRerankerRequestsTest.testParseTopics(GenerateRerankerRequestsTest.java:67)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
        at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
        at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
        at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)
        at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)
        at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
        at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
        at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)

[ERROR] io.anserini.rerank.GenerateRerankerRequestsTest.testPrebuilt  Time elapsed: 0 s  <<< ERROR!
java.lang.IllegalArgumentException: Ambiguous index reference "cacm": both a prebuilt index label and a local path exist. Please disambiguate by specifying a full local path or removing/renaming the local directory.
        at io.anserini.rerank.GenerateRerankerRequests.getIndexReader(GenerateRerankerRequests.java:205)
        at io.anserini.rerank.GenerateRerankerRequests.<init>(GenerateRerankerRequests.java:92)
        at io.anserini.rerank.GenerateRerankerRequestsTest.testPrebuilt(GenerateRerankerRequestsTest.java:51)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
        at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
        at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
        at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)
        at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)
        at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
        at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
        at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)

[ERROR] io.anserini.rerank.GenerateRerankerRequestsTest.testLocalTopics  Time elapsed: 0 s  <<< ERROR!
java.lang.IllegalArgumentException: Ambiguous index reference "cacm": both a prebuilt index label and a local path exist. Please disambiguate by specifying a full local path or removing/renaming the local directory.
        at io.anserini.rerank.GenerateRerankerRequests.getIndexReader(GenerateRerankerRequests.java:205)
        at io.anserini.rerank.GenerateRerankerRequests.<init>(GenerateRerankerRequests.java:92)
        at io.anserini.rerank.GenerateRerankerRequestsTest.testLocalTopics(GenerateRerankerRequestsTest.java:99)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
        at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
        at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
        at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)
        at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)
        at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
        at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
        at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   GenerateRerankerRequestsTest.testLocalTopics:99 » IllegalArgument Ambiguous index reference "cacm": both a prebuilt index label and a local path exist. Please disambiguate by specifying a full local path or removing/renaming the local directory.
[ERROR]   GenerateRerankerRequestsTest.testParseTopics:67 » IllegalArgument Ambiguous index reference "cacm": both a prebuilt index label and a local path exist. Please disambiguate by specifying a full local path or removing/renaming the local directory.
[ERROR]   GenerateRerankerRequestsTest.testPrebuilt:51 » IllegalArgument Ambiguous index reference "cacm": both a prebuilt index label and a local path exist. Please disambiguate by specifying a full local path or removing/renaming the local directory.
[INFO] 
[ERROR] Tests run: 7, Failures: 0, Errors: 3, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  9.351 s
[INFO] Finished at: 2025-08-18T18:10:10-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.0:test (default-test) on project anserini: 
[ERROR] 
[ERROR] Please refer to /u5/j33green/castorini/anserini/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

@lintool
Copy link
Member

lintool commented Aug 19, 2025

@JJGreen0 Please add a test case?

@lintool lintool self-requested a review August 19, 2025 18:53
@lintool lintool merged commit d25bdd6 into castorini:master Aug 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lintool lintool lintool approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JJGreen0 @lintool @suraj-subrahmanyan