Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lilyjge
Copy link
Member

@lilyjge lilyjge commented Aug 22, 2025

Add reproductions for the following:

  • msmarco-v1-doc
  • msmarco-v1-doc-segmented
  • msmarco-v2-doc
  • msmarco-v2-doc-segmented
  • msmarco-v2-passage

Fix eval metric names for msmarco-v2.1-doc for consistency.
Improve eval command logic in RunMsMarco, reduce duplicated code.
Closes #2923.

@lilyjge lilyjge requested a review from lintool August 22, 2025 20:40
Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lilyjge let's follow Pyserini: https://castorini.github.io/pyserini/2cr/msmarco-v1-doc.html

And put both v1-doc and v1-doc-segmented together? (And same with v2).

Either update this PR or go ahead and merge this PR and file new PR with the combining?

@lilyjge
Copy link
Member Author

lilyjge commented Aug 24, 2025

I will combine in this PR for msmarco-v1-doc and msmarco-v2-doc, which I added.
Do we want to combine msmarco-v2.1-doc and its segmented variant as well or keep them separate? It seems to be a special case as they each have their own section on the Anserini README.

@lintool
Copy link
Member

lintool commented Aug 24, 2025

@lilyjge go ahead and merge!

@lilyjge lilyjge merged commit 500e8d5 into castorini:master Aug 25, 2025
1 check passed
@lilyjge lilyjge deleted the msmarco-repro branch August 25, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing reproductions with prebuilt indexes: msmarco-v1-doc and msmarco-v2

2 participants